[riot-notifications] [RIOT-OS/RIOT] sys, fmt: simplify fmt_s16_dfp, and update documentation (#7499)

Joakim NohlgÄrd notifications at github.com
Wed Sep 20 11:46:42 CEST 2017


gebart requested changes on this pull request.

minor nits, looks good otherwise

> @@ -184,7 +184,7 @@ static void test_fmt_s16_dec(void)
 
 static void test_fmt_s16_dfp(void)
 {
-    char out[8] = "--------";
+    char out[13] = "-------------";

The string is too long for the buffer, the terminating null byte does not fit.

>      len = fmt_s16_dfp(out, val, fpp);
     out[len] = '\0';
-    TEST_ASSERT_EQUAL_INT(0, len);

what was the original intent of this test? it seems like it only tests the same thing as the test on line 232 after this change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7499#pullrequestreview-63919917
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20170920/6934bd5c/attachment.html>


More information about the notifications mailing list