[riot-notifications] [RIOT-OS/RIOT] at86rf2xx: add NETOPT_TX_RETRIES_NEEDED support (#7484)

Sebastian Meiling notifications at github.com
Fri Sep 29 11:21:56 CEST 2017


smlng requested changes on this pull request.



> @@ -167,6 +167,11 @@ typedef struct {
     uint8_t pending_tx;                 /**< keep track of pending TX calls
                                              this is required to know when to
                                              return to @ref at86rf2xx_t::idle_state */
+#if defined(MODULE_AT86RF232) || defined(MODULE_AT86RF233)

IMO the condition here should match the above, i.e., `AT86RF2XX_XAH_CTRL_2__ARET_FRAME_RETRIES_OFFSET`. Just to make sure its consistent and avoid failures in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7484#pullrequestreview-66099583
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20170929/e61247c6/attachment.html>


More information about the notifications mailing list