[riot-notifications] [RIOT-OS/RIOT] pkg: add support for libcose (#8895)

Francisco Acosta notifications at github.com
Mon Apr 16 18:25:18 CEST 2018


kYc0o commented on this pull request.



> @@ -0,0 +1,3 @@
+MODULE := libcose

My comment it's not related to the fact if it works or not. I know both work, but not both are correct. You can have a hint [here](https://stackoverflow.com/questions/448910/what-is-the-difference-between-the-gnu-makefile-variable-assignments-a/448973). If there are places where this is wrongly used, we might correct them in follow up PRs. I just want to have a clean PR here.

So, I'd say the correct way to do is `MODULE = libcose` and `SUBMODULES := 1`. In case I misunderstood the usages, can @cladmi give us a hand here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8895#discussion_r181802164
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20180416/6b67c3cd/attachment.html>


More information about the notifications mailing list