[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common: external interrupt fix and refactor (#8951)

Francisco Acosta notifications at github.com
Mon Apr 16 23:32:08 CEST 2018


kYc0o commented on this pull request.

Just a small question. I consider this a very good cleanup and actually a bug fix. Thus I'd like to get it into the release. I'll make more testing tomorrow.

Thanks @ZetaR60 to tackle this!

>      }
 #if defined(EICRB)
     else {
-        EICRB |= (flank << (pin_num * 2) % 4);
+        EICRB |= (flank << ((int_num % 4) * 2));

Can you tell more about this change? At a first glance it looks like the same, but I know there's a difference. I also wonder it worked in the past.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8951#pullrequestreview-112595332
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20180416/cd3f536e/attachment.html>


More information about the notifications mailing list