[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common: __exit_isr thread_yield (#8988)

Joakim NohlgÄrd notifications at github.com
Fri Apr 20 05:52:26 CEST 2018


gebart requested changes on this pull request.

Good improvement! For consistency, I would prefer to let the enter/exit isr calls in the UART driver to remain in each ISR instead of the central IRQ handler. 

>  }
 
 #ifdef UART_0_ISR
 ISR(UART_0_ISR, ISR_BLOCK)
 {
-    __enter_isr();

I prefer the original design where enter isr is the first line of each ISR 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8988#pullrequestreview-113841981
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20180420/82640ca2/attachment.html>


More information about the notifications mailing list