[riot-notifications] [RIOT-OS/RIOT] drivers/periph: add basic API to read/write data to EEPROM (#8862)

Alexandre Abadie notifications at github.com
Tue Apr 24 10:46:04 CEST 2018


aabadie commented on this pull request.



> @@ -201,3 +206,24 @@ void flashpage_write(int page, const void *data)
         flashpage_write_raw(page_addr, data, FLASHPAGE_SIZE);
     }
 }
+
+#ifdef MODULE_PERIPH_EEPROM

> I think this files is missing the #include "periph/eeprom.h"?

Agreed

> But would also suggest to not add this to flashpage driver but rather have a separate file.

How do you share code between different periph ? Here I'm reusing the lock/unlock functions from flashpage periph, since they are the same.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8862#discussion_r183650553
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20180424/2310a825/attachment.html>


More information about the notifications mailing list