[riot-notifications] [RIOT-OS/RIOT] cc2538/include/periph_cpu.h: Changed UART configuration format for cc2538. (#8345)

Hauke Petersen notifications at github.com
Wed Feb 7 13:36:31 CET 2018


haukepetersen requested changes on this pull request.

Just this one small thing, otherwise the code looks good to me.

>  }
+
+void uart_clockon(uart_t uart)

What are these two functions (clockon/clockoff) about? They are not part of the UART interface, so they should not be non-static. Further they are not used anywhere in the code, so why have them? I suspect that the code from this functions should probalby rather be integrated into the poweron/off functions, right?!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8345#pullrequestreview-94689135
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20180207/df313272/attachment.html>


More information about the notifications mailing list