[riot-notifications] [RIOT-OS/RIOT] Improve shell_commands (#8564)

Joakim NohlgÄrd notifications at github.com
Thu Feb 15 15:06:24 CET 2018


gebart commented on this pull request.

The idea is good in my opinion, but I think the implementation has some flaws. 
The shell command list should be const and placed in .rodata or .text to avoid taking up ram at runtime. It would also be beneficial if it was possible to only use one single ldscript for all platforms, to make it easier to maintain in the future.
Can this make use of the proposed cross file arrays in the xfa PR? 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8564#pullrequestreview-96857117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20180215/804192b5/attachment.html>


More information about the notifications mailing list