[riot-notifications] [RIOT-OS/RIOT] drivers/*: unify drivers params definition scheme (#7937)

Francisco Acosta notifications at github.com
Wed Feb 28 15:45:37 CET 2018


kYc0o commented on this pull request.



>   *
  * @return              0 on success
  * @return              -1 on error
  */
-int lps331ap_init(lps331ap_t *dev, i2c_t i2c, uint8_t address, lps331ap_rate_t rate);
+int lps331ap_init(lps331ap_t *dev, const lps331ap_params_t * params);

Yeah but here you're not modifying the params scheme but the API for this driver. I see it takes the params as input but what I argue here is that you modified the API, the params and structs just to fit with the new params scheme. Too much changes in a row...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7937#discussion_r171265432
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20180228/e68de1e5/attachment-0001.html>


More information about the notifications mailing list