[riot-notifications] [RIOT-OS/RIOT] sys/posix: make posix module provide only headers. (#10357)

Juan I Carrano notifications at github.com
Fri Nov 9 15:14:58 CET 2018


### Contribution description

The build system contains several instances of
```
 INCLUDES += -I$(RIOTBASE)/sys/posix/include
```
This is bypassing the module management system, by directly accesing headers without depending on a module. The module is the `posix` module.

That line is also added when one of the posix_* modules is requested.

[According to the docs](http://doc.riot-os.org/group__posix.html#details), the `posix` module provides headers only, but in reality there is also inet.c.

This patch:

- Moves `inet.c` into `posix_inet`, thus leaving `posix` as a headers-only module.
- Makes `posix_*` modules depend on `posix`, thus removing the explicit `INCLUDES+=...` in `sys/Makefile.include`.
- Ocurrences of `INCLUDES+=...` are replaced by an explicit dependency on `posix`.

### Testing procedure

This is a build system change, that should not change any behaviour. If I screwed up the CI should catch any modules that fail to build.

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/10357

-- Commit Summary --

  * sys/posix: make posix module provide only headers.

-- File Changes --

    M Makefile.dep (14)
    M pkg/ccn-lite/Makefile.dep (1)
    M pkg/ccn-lite/Makefile.include (1)
    M pkg/libcoap/Makefile.dep (1)
    M pkg/libcoap/Makefile.include (3)
    M sys/Makefile.include (15)
    D sys/posix/Makefile (1)
    R sys/posix/inet/inet.c (0)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/10357.patch
https://github.com/RIOT-OS/RIOT/pull/10357.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20181109/e7ff2adb/attachment.html>


More information about the notifications mailing list