[riot-notifications] [RIOT-OS/RIOT] gnrc_icmpv6_error: fix and use where appropriate (#8594)

Koen Zandberg notifications at github.com
Wed Nov 14 13:13:47 CET 2018


bergzand commented on this pull request.



> @@ -742,13 +745,19 @@ static void _receive(gnrc_pktsnip_t *pkt)
 #ifdef MODULE_GNRC_IPV6_WHITELIST
         if (!gnrc_ipv6_whitelisted(&((ipv6_hdr_t *)(pkt->data))->src)) {
             DEBUG("ipv6: Source address not whitelisted, dropping packet\n");
+#ifdef MODULE_GNRC_ICMPV6_ERROR
+            gnrc_icmpv6_error_dst_unr_send(ICMPV6_ERROR_DST_UNR_PROHIB, pkt);
+#endif

Does it make sense to provide a single stub for `gnrc_icmpv6_error_dst_unr_send()` when `MODULE_GNRC_ICMPV6_ERROR` is not included? then you don't have to put `ifdefs` around all the occurrences in the code here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8594#pullrequestreview-174829270
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20181114/b5cd334d/attachment-0001.html>


More information about the notifications mailing list