[riot-notifications] [RIOT-OS/RIOT] cpu/nrf52/radio: initial support for nrf52's ieee802.15.4 radio (#10268)

Martine Lenders notifications at github.com
Fri Nov 16 11:40:14 CET 2018


miri64 commented on this pull request.



> +
+    /* switch to RX mode */
+    _enable_rx();
+
+    return 0;
+}
+
+static int _send(netdev_t *dev,  const iolist_t *iolist)
+{
+    (void)dev;
+
+    DEBUG("[nrf802154] Send a packet\n");
+
+    assert(iolist);
+
+    mutex_lock(&txlock);

Wait... how can it be that the thread passes this mutex, if the unlock happens in the ISR when TX complete?

https://github.com/RIOT-OS/RIOT/blob/427111035fcbed0947efe283872d6ca26f2c103d/cpu/nrf52/radio/nrf802154/nrf802154.c#L400-L407

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10268#pullrequestreview-175745100
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20181116/bd1f88f2/attachment.html>


More information about the notifications mailing list