[riot-notifications] [RIOT-OS/RIOT] drivers/enc28j60: fix of #9784 (#9806)

Marian Buschsieweke notifications at github.com
Mon Nov 19 09:49:45 CET 2018


maribu commented on this pull request.

Thank you for addressing this issue. I believe clearing the PKTIF flag in the EIR register in line 485 is not required according to the datasheet (see comment above) - but I'm not sure about that.

> @@ -470,6 +482,7 @@ static void nd_isr(netdev_t *netdev)
                 DEBUG("[enc28j60] isr: packet received\n");
                 netdev->event_callback(netdev, NETDEV_EVENT_RX_COMPLETE);
             } while (cmd_rcr(dev, REG_B1_EPKTCNT, 1) > 0);
+            cmd_bfc(dev, REG_EIR, -1, EIR_PKTIF);

> After decrementing, if EPKTCNT is ‘0’, the EIR.PKTIF flag will automatically be cleared.

Citing section 7.2.4 on page 45 in the [datasheet](http://ww1.microchip.com/downloads/en/DeviceDoc/39662b.pdf). I assume this line could be dropped.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9806#pullrequestreview-176189063
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20181119/805b4450/attachment.html>


More information about the notifications mailing list