[riot-notifications] [RIOT-OS/RIOT] periph/gpio: support for extension API (part 2) (#9958)

Gunar Schorcht notifications at github.com
Sat Nov 24 19:30:00 CET 2018


gschorcht commented on this pull request.



> @@ -152,6 +152,12 @@ ifneq (,$(filter fxos8700,$(USEMODULE)))
   FEATURES_REQUIRED += periph_i2c
 endif
 
+ifneq (,$(filter extend_gpio,$(USEMODULE)))
+  FEATURES_REQUIRED += periph_gpio
+  FEATURES_REQUIRED += periph_gpio_irq

Is it really necessary to always use the `periph_gpio_irq` module? IMHO, it should be the other way around. That is, the interrupt-related parts of the API should only be activated if the module `periph_gpio_irq` is used by someone.
```
#if MODULE_PERIPH_GPIO_IRQ
...
#endif
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9958#pullrequestreview-178058600
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20181124/210d791f/attachment.html>


More information about the notifications mailing list