[riot-notifications] [RIOT-OS/RIOT] periph/gpio: support for extension API (part 2) (#9958)

Gunar Schorcht notifications at github.com
Mon Nov 26 15:21:11 CET 2018


gschorcht commented on this pull request.



> @@ -152,6 +152,11 @@ ifneq (,$(filter fxos8700,$(USEMODULE)))
   FEATURES_REQUIRED += periph_i2c
 endif
 
+ifneq (,$(filter extend_gpio,$(USEMODULE)))

I'm sorry if it seems to be a bit nit-picking, but could move this 
```
ifneq (,$(filter extend_gpio,$(USEMODULE)))
```
block before the 
```
ifneq (,$(filter feetech,$(USEMODULE)))
```
block to keep alphabetical order, please. Maybe you placed it there because you initially called it `gpio_extend`.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9958#pullrequestreview-178310470
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20181126/d478754e/attachment.html>


More information about the notifications mailing list