[riot-notifications] [RIOT-OS/RIOT] sys: Add Link Format module (#11189)

Ken Bannister notifications at github.com
Mon Apr 1 02:34:36 CEST 2019


kb2ma commented on this pull request.



> +    CLIF_PARAM_MEDIA         = 3,  /**< media */
+    CLIF_PARAM_TITLE         = 4,  /**< title */
+    CLIF_PARAM_TITLE_EXT     = 5,  /**< title* */
+    CLIF_PARAM_TYPE          = 6,  /**< type */
+    CLIF_PARAM_RT            = 7,  /**< rt */
+    CLIF_PARAM_IF            = 8,  /**< if */
+    CLIF_PARAM_SZ            = 9,  /**< sz */
+    CLIF_PARAM_CT            = 10, /**< ct */
+    CLIF_PARAM_EXT           = 11  /**< extensions */
+} clif_param_type_t;
+
+/**
+ * @brief Link format parameter descriptor
+ */
+typedef struct {
+    clif_param_type_t type;        /**< type of parameter */

Is it worthwhile to include this here and generate it with each call to `clif_get_param()`? Maybe create a separate `unsigned clif_get_param_type(const char *key)` and let the user decide when to use it.

In this case the `char *ext` attribute becomes `char *key`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11189#pullrequestreview-220893956
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190331/85f542da/attachment.html>


More information about the notifications mailing list