[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of ADC channels in board definitions (#11289)

Leandro Lanzieri notifications at github.com
Mon Apr 1 09:37:48 CEST 2019


leandrolanzieri requested changes on this pull request.

@gschorcht Though last changes fix the compiling problem I'm not sure if this is the correct way to handle this dependency issue. Looking at other CPUs I can see that it is common in RIOT to include some `periph` module directly in the CPU Makefile.include, so it's clear that the issue is out of the scope of this PR.

We could merge this as a *temporary* solution while the dependencies are fixed. Maybe @haukepetersen @jcarrano or @kaspar030 have a better idea on how to proceed? 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11289#pullrequestreview-220957945
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190401/dcfe4c66/attachment.html>


More information about the notifications mailing list