[riot-notifications] [RIOT-OS/RIOT] Add support for "External PA/LNA Control" in mrf24j40 driver (useful … (#10625)

Peter Kietzmann notifications at github.com
Mon Apr 1 14:04:01 CEST 2019


PeterKietzmann commented on this pull request.



> @@ -115,6 +115,10 @@ extern "C" {
 
 #define MRF24J40_MAX_FRAME_RETRIES      (3U)        /**< Number of frame retries (fixed) */
 
+#ifndef MRF24J40_USE_EXT_PA_LNA
+#define MRF24J40_USE_EXT_PA_LNA         (0U)        /**< Enable external PA/LNA control (Section 4.2 of datasheet) for MRF24J40MC/MD/ME */

Thanks for addressing! Unfortunately this doesn't comply with out [Coding Conventions](https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions):"*Line length: aim for no more than 80 characters per line, the absolute maximum should be 100 characters per line*". I'd suggest you simply add ya `brief` like for example [here](https://github.com/RIOT-OS/RIOT/blob/master/drivers/include/at86rf2xx.h#L91)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10625#pullrequestreview-221069769
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190401/ced24208/attachment.html>


More information about the notifications mailing list