[riot-notifications] [RIOT-OS/RIOT] boards/common/nrf52xxxdk: Fixed periph conf (#11206)

Alexandre Abadie notifications at github.com
Tue Apr 2 08:08:23 CEST 2019


aabadie requested changes on this pull request.

Finally found some time to look at this one. Sorry for the delay.

I looked at the user guides of both nrf52840dk and nrf52dk. The changes proposed by this PR are ok for nrf52840dk but they leave nrf52dk in a wrong state: SPI pins on this board (as defined for a compatible Arduino pinout) are P0.25/24/23 whereas RIOT uses P0.15/14/13.

I would suggest to move the SPI configuration out from the common file, since they are obviously different. This way there's no need for the `NRF52XXXDK_SPI_PORT` macro, that I don't really like.

This PR is also changing the way pins are defined, using the GPIO_PIN macro. This change should be in its own commit.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11206#pullrequestreview-221463054
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190402/c503cf6d/attachment.html>


More information about the notifications mailing list