[riot-notifications] [RIOT-OS/RIOT] pkg: Initial introduction of ubasic package (#11319)

Kaspar Schleiser notifications at github.com
Wed Apr 3 00:08:08 CEST 2019


kaspar030 commented on this pull request.



> @@ -0,0 +1,15 @@
+include ../Makefile.tests_common
+
+TEST_ON_CI_WHITELIST += all
+
+USEPKG += ubasic
+
+# ubasic_init_peek_poke used in those tests is not exposed
+CFLAGS += -Wno-implicit-function-declaration
+
+include $(RIOTBASE)/Makefile.include
+
+clean: ..rm-main

I think I'd prefer an empty main.c, or as empty as gcc permits.

Fiddling with files within the source tree is usually a bad idea. E.g., CI builds multiple boards in the same checkout.

I suggest including tests.c in the pkg makefile depending on a make variable. "main()" doesn't have to be in the application folder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11319#discussion_r271514628
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190402/07471927/attachment.html>


More information about the notifications mailing list