[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of ADC channels in board definitions (#11289)

Gunar Schorcht notifications at github.com
Wed Apr 3 11:02:46 CEST 2019


@leandrolanzieri 
> @cladmi has pointed out that the peripheral directory should be specified differently, by including include $(RIOTMAKE)/periph.mk in the Makefile instead of include $(RIOTBASE)/Makefile.base

I see, I have tried it and it compiles indeed only the `periph/*.c` that are required by modules. Unfortunatly, it would require some changes in all `periph/*.c` using `#if MODULE_PERIPH_*` more strictly. Otherwise there are linker errors.

How do we proceed. Should I provide a PR with required changes in `periph/*.c` that has to be merged before these PRs can be rebased?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11289#issuecomment-479403735
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190403/f442cf3d/attachment.html>


More information about the notifications mailing list