[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of ADC channels in board definitions (#11289)

Leandro Lanzieri notifications at github.com
Thu Apr 4 08:40:43 CEST 2019


@gschorcht 
> you will find the changes for `periph_*` submodules as we discussed it here

Thanks for addressing the issue so quickly.

> But I'm not sure if these significant changes make really sense, just to solve the small problem in this PR

IMHO fixing these dependencies is important in general, not just for this PR, and should be addressed before this cleanup. @cladmi do you have any opinion on this?

> * PRs #11289 to #11294 are tested and work. If we wait for PR #11337, it might become necessary to review and test all of them again once they are rebased onto PR #11337.

Aren't some changes going to be needed anyways if #11289 - #11294 are merged before #11337? I'm happy to review and test them again.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11289#issuecomment-479770524
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190403/b6c07213/attachment.html>


More information about the notifications mailing list