[riot-notifications] [RIOT-OS/RIOT] Add support for "External PA/LNA Control" in mrf24j40 driver (useful … (#10625)

benpicco notifications at github.com
Thu Apr 4 11:00:06 CEST 2019


benpicco commented on this pull request.



> @@ -87,6 +87,11 @@ void mrf24j40_init(mrf24j40_t *dev)
     mrf24j40_reg_write_short(dev, MRF24J40_REG_BBREG2, MRF25J40_BBREG2_CCAMODE1 );
     mrf24j40_reg_write_short(dev, MRF24J40_REG_CCAEDTH, 0x60);
     mrf24j40_reg_write_short(dev, MRF24J40_REG_BBREG6, MRF24J40_BBREG6_RSSIMODE2 );
+#if MRF24J40_USE_EXT_PA_LNA
+    mrf24j40_reg_write_long(dev, MRF24J40_REG_TESTMODE, (MRF24J40_TESTMODE_TESTMODE2 |
+                                                         MRF24J40_TESTMODE_TESTMODE1 |
+                                                         MRF24J40_TESTMODE_TESTMODE0));

Adding `MRF24J40_TESTMODE_RSSIWAIT0` here to make 0x0F like in the Microchip driver increased the RSSI on a receiving samr21-xpro from -38 dBm to -34 dBm.

The datasheet just refers to this as the "Optimized value (default)".
Why it switches to `MRF24J40_TESTMODE_RSSIWAIT1` for Clear Channel Assessment is still unknown to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10625#pullrequestreview-222635773
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190404/f07b4d4f/attachment.html>


More information about the notifications mailing list