[riot-notifications] [RIOT-OS/RIOT] Add support for "External PA/LNA Control" in mrf24j40 driver (useful … (#10625)

benpicco notifications at github.com
Thu Apr 4 11:03:11 CEST 2019


benpicco commented on this pull request.



> @@ -87,6 +87,11 @@ void mrf24j40_init(mrf24j40_t *dev)
     mrf24j40_reg_write_short(dev, MRF24J40_REG_BBREG2, MRF25J40_BBREG2_CCAMODE1 );
     mrf24j40_reg_write_short(dev, MRF24J40_REG_CCAEDTH, 0x60);
     mrf24j40_reg_write_short(dev, MRF24J40_REG_BBREG6, MRF24J40_BBREG6_RSSIMODE2 );
+#if MRF24J40_USE_EXT_PA_LNA

Adding a
```
    mrf24j40_reg_write_short(dev, MRF24J40_REG_TRISGPIO, 0x08);
    mrf24j40_reg_write_short(dev, MRF24J40_REG_GPIO, 0x08);
```
didn't hurt the MRF24J40MD and if it helps the MRF24J40MC we might as well add it as well add it unconditionally.
I did not test if it negatively affects power consumption on the D module though (where the GPIO should be handled automatically) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10625#pullrequestreview-222637322
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190404/fcb35d08/attachment-0001.html>


More information about the notifications mailing list