[riot-notifications] [RIOT-OS/RIOT] sam0_common: make Timer implementation common across all sam0 MCUs (#11336)

benpicco notifications at github.com
Fri Apr 5 17:41:56 CEST 2019


Thank you for testing!
I don't have a saml21 here for testing, so I tried it on the samr21-xpro only to notice that it crashes when trying to configure `TIMER_DEV(1)` for reference - which makes me think I probably should implement 8/16 bit mode too as otherwise we only have one timer on this MCU.

After adding it to `SINGLE_TIMER_BOARDS` the test gets stuck though (both on master and my branch):

```
2019-04-05 17:29:50,454 - INFO # Statistical benchmark for timers
2019-04-05 17:29:50,460 - INFO # Running timer test with seed 123 using Tiny Mersenne Twister PRNG.
2019-04-05 17:29:50,462 - INFO # TEST_MIN = 16
2019-04-05 17:29:50,463 - INFO # TEST_MAX = 128
2019-04-05 17:29:50,464 - INFO # TEST_MIN_REL = 0
2019-04-05 17:29:50,472 - INFO # TEST_MAX_REL = 112
2019-04-05 17:29:50,473 - INFO # TEST_NUM = 113
2019-04-05 17:29:50,475 - INFO # log2(TEST_NUM - 1) = 6
2019-04-05 17:29:50,476 - INFO # state vector elements per variant = 7
2019-04-05 17:29:50,478 - INFO # number of variants = 8
2019-04-05 17:29:50,479 - INFO # sizeof(state) = 32 bytes
2019-04-05 17:29:50,481 - INFO # state vector total memory usage = 1792 bytes
2019-04-05 17:29:50,486 - INFO # TIM_TEST_DEV = 0, TIM_TEST_FREQ = 1000000, TIM_TEST_CHAN = 0
2019-04-05 17:29:50,489 - INFO # TIM_REF_DEV  = 0, TIM_REF_FREQ  = 1000000
2019-04-05 17:29:50,491 - INFO # USE_REFERENCE = 1
2019-04-05 17:29:50,494 - INFO # TEST_PRINT_INTERVAL_TICKS = 30000000
2019-04-05 17:29:50,509 - INFO # Expected error variance due to truncation in tick conversion: 0
2019-04-05 17:29:50,510 - INFO # Calibrating spin delay...
2019-04-05 17:29:50,511 - INFO # spin_max = 90
2019-04-05 17:29:50,511 - INFO # Estimating benchmark overhead...
2019-04-05 17:29:50,657 - INFO # overhead_target = 17 (s2 = 0)
2019-04-05 17:29:50,659 - INFO # overhead_read = 17 (s2 = 0)
2019-04-05 17:29:50,661 - INFO # exp_mask = 00000007
2019-04-05 17:29:50,663 - INFO # max interval = 255
```

The discrepancy is surprising as the initialization is still the same between [the new config](https://github.com/RIOT-OS/RIOT/blob/c09ac47909f8f7358f0ba394a59d7cbbcdb4af80/boards/saml21-xpro/include/periph_conf.h#L41) and [the old one](https://github.com/RIOT-OS/RIOT/blob/master/cpu/saml21/periph/timer.c#L56).

I'll try to reproduce this issue so I can fix it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11336#issuecomment-480323461
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190405/d90f5bad/attachment.html>


More information about the notifications mailing list