[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: don't autoconfig IPv6 address without L2 addr (#10483)

Martine Lenders notifications at github.com
Fri Apr 5 20:48:19 CEST 2019


> I asked for a rebase because the PR is 4 months old. I don't know if any updated code in other parts of the network stack might impact the functionality in this PR. At any rate, not necessary now. I rebased myself for testing.

Since murdock is doing this as well before compiling, I guess this isn't necessary at all ;-).

> This PR still tests fine. My only question is when DEBUG is on in this module. I see the sequence of messages below. Is it confusing to see both line 2 and line 3, which was added by this PR? I don't know enough about debugging the network layer to give an opinion.
> 
> ```
> INFO # nib: add address based on fe80::/64 automatically to interface 7
> INFO # nib: add address based on fe80::/64 automatically to interface 8
> INFO # nib: interface 8 has no link-layer addresses
> ```

Ah, will move the check above the first DEBUG. This way it is less confusing, I hope.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10483#issuecomment-480383775
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190405/1f2f2f7a/attachment-0001.html>


More information about the notifications mailing list