[riot-notifications] [RIOT-OS/RIOT] tests/bench_timers: improve test to work on some SAM based boards (#11346)

Federico Pellegrin notifications at github.com
Sat Apr 6 06:25:16 CEST 2019


@benpicco thanks for checking the code! I first wanted to do that too indeed as was sounding more to solve the problem than a workaround. 
But then I opted for changing the test since changing this in `timer_init()` would change the behaviour of that function quite a bit as now the timer will never get overwritten until it is running (and what I found also not so polite is that it will even return 0, therefore not notify anything!), while with the change it would always use the last one. 
While the second one may be more correct (or at least getting an error to tell me that it was not inited) it was sounding as a big behaviour change that may need more discussion and a separate PR in case (or your PR of SAM timers rewrite :) ) and this PR would address simply the benchmark test execution by itself.

I checked a few others CPUs now and in general most of them indeed either overwrite the previous timer or return an error if it is re-inited. Maybe this is something that could be uniformed among all the CPUs indeed.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11346#issuecomment-480473075
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190405/19bc38ec/attachment.html>


More information about the notifications mailing list