[riot-notifications] [RIOT-OS/RIOT] pkg/ubasic: add support for BASIC's "shell" statement. (#11349)

Martine Lenders notifications at github.com
Mon Apr 8 11:49:39 CEST 2019


miri64 requested changes on this pull request.

There are some dependency issues in this PR, which we should rather discuss seperately. 

> @@ -29,3 +30,18 @@ int _reboot_handler(int argc, char **argv)
 
     return 0;
 }
+
+int _echo_handler(int argc, char **argv)

This belongs into its own PR. 

> @@ -304,3 +304,17 @@ void shell_run(const shell_command_t *shell_commands, char *line_buf, int len)
         print_prompt();
     }
 }
+
+#ifdef MODULE_SHELL_COMMANDS
+/* Provide standard system() function */
+int system(const char *command)

This as well.

Also I think this rather belongs into the POSIX module and `shell_commands` shouldn't be a dependency. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11349#pullrequestreview-223741226
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190408/6c471857/attachment-0001.html>


More information about the notifications mailing list