[riot-notifications] [RIOT-OS/RIOT] pkg/ubasic: add support for BASIC's "shell" statement. (#11349)

Martine Lenders notifications at github.com
Mon Apr 8 12:52:20 CEST 2019

miri64 commented on this pull request.

> @@ -304,3 +304,17 @@ void shell_run(const shell_command_t *shell_commands, char *line_buf, int len)
+/* Provide standard system() function */
+int system(const char *command)

> since system() is C99/C89 and placing it is the easiest way to make sure system() is tied to shell_commands.

You can have shell commands without having the module `shell_commands` (which provides a number of *default* shell commands), so I don't understand the requirement for `shell_commands`.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190408/f43a83bc/attachment-0001.html>

More information about the notifications mailing list