[riot-notifications] [RIOT-OS/RIOT] drivers/sx127x: add support for rx and tx switch pin (#11316)

Alexandre Abadie notifications at github.com
Mon Apr 8 21:06:41 CEST 2019


aabadie requested changes on this pull request.

I think I would prefer `SX127X_USE_TX_SWITCH` and `SX127X_USE_RX_SWITCH` macro names.

It would be great if these macro were documented somewhere (I have no suggestion right now).

> @@ -216,6 +216,10 @@ typedef struct {
     gpio_t dio5_pin;                   /**< Interrupt line DIO5 (not used) */
 #ifdef SX127X_USE_DIO_MULTI
     gpio_t dio_multi_pin;              /**< Interrupt line for multiple IRQs */
+#endif
+#if defined(SX127X_TX_SWITCH) || defined(SX127X_RX_SWITCH)

```suggestion
#if defined(SX127X_RX_SWITCH)
    gpio_t rx_switch_pin;              /**< Rx antenna switch */
#endif
#if defined(SX127X_TX_SWITCH)
    gpio_t tx_switch_pin;              /**< Tx antenna switch */
#endif
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11316#pullrequestreview-224031622
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190408/d21b2152/attachment.html>


More information about the notifications mailing list