[riot-notifications] [RIOT-OS/RIOT] pkg/ubasic: add support for BASIC's "shell" statement. (#11349)

Martine Lenders notifications at github.com
Tue Apr 9 09:48:45 CEST 2019


miri64 commented on this pull request.



> @@ -304,3 +304,17 @@ void shell_run(const shell_command_t *shell_commands, char *line_buf, int len)
         print_prompt();
     }
 }
+
+#ifdef MODULE_SHELL_COMMANDS
+/* Provide standard system() function */
+int system(const char *command)

> I you don't have shell_commands, then you don't have access to any command from within `system()`

Well, that seems to be more of an issue of the current implementation. So I see it as premature to establish a dependency that in reality should not be there (I would expect e.g. `system("udp …")` to work if I call it with `gnrc_networking`.

> In 2038, when we finally get XFAs, this won't be an issue (if we survive the UNIX timestamp overflow)

ztimer will handle the latter. ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11349#discussion_r273363717
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190409/e3e8675e/attachment.html>


More information about the notifications mailing list