[riot-notifications] [RIOT-OS/RIOT] boards/common/nrf52xxxdk: Fixed periph conf (#11206)

Alexandre Abadie notifications at github.com
Wed Apr 10 16:18:32 CEST 2019


aabadie commented on this pull request.



> @@ -34,16 +34,18 @@ extern "C" {
  * @name    SPI configuration
  * @{
  */
+#ifndef SPI_NUMOF /* <-- Allow overwriting SPI_NUMOF from periph_conf */

What about moving this spi config in its own default include file in common nrf52 directory (like cfg_rtt_default.h) ?
Only ruuvitag and the other board would include it in their `periph_conf.h` and you can remove it from this file. And then no to define the structure before including periph_conf_common in nrf52dk/nrf52840dk.

Do this makes sense for you @maribu ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11206#pullrequestreview-225001263
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190410/2e999ef3/attachment.html>


More information about the notifications mailing list