[riot-notifications] [RIOT-OS/RIOT] drivers/sx127x: add support for rx and tx switch pin (#11316)

Alexandre Abadie notifications at github.com
Wed Apr 10 16:36:35 CEST 2019


aabadie commented on this pull request.



> @@ -216,6 +216,10 @@ typedef struct {
     gpio_t dio5_pin;                   /**< Interrupt line DIO5 (not used) */
 #ifdef SX127X_USE_DIO_MULTI
     gpio_t dio_multi_pin;              /**< Interrupt line for multiple IRQs */
+#endif
+#if defined(SX127X_USE_TX_SWITCH) || defined(SX127X_USE_RX_SWITCH)

Very minor: I would guard each `rx/tx_switch_pin` attribute of the struct with it's corresponding macro.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11316#pullrequestreview-225013588
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190410/b3e4f412/attachment.html>


More information about the notifications mailing list