[riot-notifications] [RIOT-OS/RIOT] cpu/cortexm_common: function to check address validity (#11358)

Kaspar Schleiser notifications at github.com
Wed Apr 10 22:55:13 CEST 2019


kaspar030 requested changes on this pull request.

Looking good! Minor nits. Feel free to squash directly!

> @@ -0,0 +1,10 @@
+FEATURES_REQUIRED += cpu_check_address
+
+BOARD ?= nucleo-l152re
+
+USEMODULE += shell
+USEMODULE += shell_commands
+
+include ../Makefile.tests_common

usually tests include this first. the board selection must go above that, though.

Is there any reason not to use samr21-xpro, which is usually the first choice if native won't work, but there are no other restrictions?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11358#pullrequestreview-225213186
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190410/d072932f/attachment.html>


More information about the notifications mailing list