[riot-notifications] [RIOT-OS/RIOT] boards/common/nrf52xxxdk: Fixed periph conf (#11206)

Marian Buschsieweke notifications at github.com
Thu Apr 11 10:38:33 CEST 2019


@aabadie: It seems [Github sometimes fails to handle rebases properly](https://help.github.com/en/articles/why-are-my-commits-in-the-wrong-order), this is the correct order of commits (from most recent to the oldest):

```
commit c6bd64e3a4ef86cc5795c14d0087ad8ec98b1888
Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
Date:   Wed Apr 10 16:43:27 2019 +0200

    boards/nrf52840dk: Arduino-compatible SPI config
    
    Added a SPI config that allows using Arduino-Shields that use SPI via the
    Arduino-ICSP header

commit ccd7679a3b66e614693f9a8485dbe37d50ad55a6
Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
Date:   Wed Apr 10 16:43:16 2019 +0200

    boards/nrf52dk: Arduino-compatible SPI config
    
    Added a SPI config that allows using Arduino-Shields that use SPI via the
    Arduino-ICSP header

commit 2d022795f4c422b2b38eb249c5f467e47c351b55
Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
Date:   Thu Apr 11 09:35:40 2019 +0200

    boards/nrf52832-mdk: Use default SPI config

commit 1280bf3d386a6a427b680872136a0743cf688abb
Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
Date:   Thu Apr 11 09:35:16 2019 +0200

    boards/nrf52840-mdk: Use default SPI config

commit be061d76a196d93a9b34932a0969373e50299d40
Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
Date:   Wed Apr 10 16:33:29 2019 +0200

    boards/common/nrf52xxxdk: Split off SPI config
    
    Moved SPI config from boards/common/nrf52xxxdk/include/periph_config.h to
    boards/common/nrf52/include/cfg_spi_default.h. This allows all nRF52 based
    boards to use this SPI config if applicable and also allows nRF52*-DK boards
    to use custom SPI configs, if needed.

commit 4d7426e13ca689eb26f5cbc1a20dec8e9d5d2ea9
Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
Date:   Wed Apr 10 16:24:42 2019 +0200

    boards/common/nrf52xxxdk: Use GPIO_PIN in SPI conf
```

If I read the help article above correctly, this should not be a problem for merging.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11206#issuecomment-482022989
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190411/15209ec2/attachment.html>


More information about the notifications mailing list