[riot-notifications] [RIOT-OS/RIOT] sam0_common: make RTC implementation common across all sam0 MCUs (#11317)

Dylan Laduranty notifications at github.com
Fri Apr 12 12:59:31 CEST 2019


dylad commented on this pull request.

I'll retest on all my boards asap.

>  
-    /* Software Reset the RTC */
-    RTC->MODE2.CTRLA.bit.SWRST = 1;
-    /* Wait end of reset */
-    while (RTC->MODE2.CTRLA.bit.SWRST);
+void rtc_init(void)
+{
+    rtc_poweron();

I don't think it's useful to enable it right know as we will disable it a few line after.
I would say to power_off at the beginning of rtc_init and power_on at the end. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11317#pullrequestreview-226018578
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190412/3a07f758/attachment.html>


More information about the notifications mailing list