[riot-notifications] [RIOT-OS/RIOT] boards/particle-{xenon, argon, boron}: add initial support (#10563)

Francisco notifications at github.com
Fri Apr 12 18:04:35 CEST 2019


fjmolinas commented on this pull request.

Looks good in general, tested with Xenon will test for other boards son. Some comments,

- Add board to applications whitelist and pertinent tests (eg: nimble or other bluetooth related).
- What test's did you run for this board? Did you test peripherals implementation? If possible provide a list.

I will leave the test suit running on boron and get back to you on the result. 

- 

> @@ -0,0 +1,44 @@
+/**
+ at defgroup    boards_common_particle-mesh Particle Mesh common
+ at ingroup     boards
+ at brief       Common support for the Particle Mesh boards family (Xenon, Argon, Boron)
+
+### General information

I might add a comment stating that the reset button on the board doens't actually reset the board (It took me some time to realize this).

> @@ -0,0 +1,24 @@
+export CPU_MODEL = nrf52840xxaa
+
+# set default port depending on operating system
+PORT_LINUX ?= /dev/ttyUSB0
+PORT_DARWIN ?= $(firstword $(sort $(wildcard /dev/tty.SLAB_USBtoUART*)))
+
+# add the common header files to the include path
+INCLUDES += -I$(RIOTBOARD)/common/particle-mesh/include
+
+# This board uses a DAP-Link programmer
+# Flashing support is provided through pyocd (default) and openocd.
+# For openocd, a version built against the development branch and containing
+# the support for nrf52 cpu is required.
+PROGRAMMER ?= pyocd

anyway of resetting board after flashing?

> +In this case, OpenOCD can also be used. For the moment, the latest stable
+version of OpenOCD (0.10) doesn't contain any support for nrf52 but versions
+built against the actual development version can be used.
+
+To flash the board with OpenOCD, use the `PROGRAMMER` variable:
+```
+    PROGRAMMER=openocd make BOARD=particle-mesh -C examples/hello-world flash
+```
+
+### Accessing STDIO via UART
+
+The STDIO is not accessible via the USB port.
+
+To access the STDIO of RIOT, a FTDI to USB converter needs to be plugged to
+the RX/TX pins on the board.
+

Since The board can't be reset thre the button I would mention that it can be reseted by calling` make reset`

> +# set default port depending on operating system
+PORT_LINUX ?= /dev/ttyUSB0
+PORT_DARWIN ?= $(firstword $(sort $(wildcard /dev/tty.SLAB_USBtoUART*)))
+
+# add the common header files to the include path
+INCLUDES += -I$(RIOTBOARD)/common/particle-mesh/include
+
+# This board uses a DAP-Link programmer
+# Flashing support is provided through pyocd (default) and openocd.
+# For openocd, a version built against the development branch and containing
+# the support for nrf52 cpu is required.
+PROGRAMMER ?= pyocd
+ifeq (pyocd,$(PROGRAMMER))
+  # The board is not recognized automatically by pyocd, so the CPU target
+  # option is passed explicitly
+  export FLASH_TARGET_TYPE ?= -t nrf52840

This is not working for when a stlink is connected on a different port, is this expected behaviour?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10563#pullrequestreview-226152252
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190412/92fadeeb/attachment-0001.html>


More information about the notifications mailing list