[riot-notifications] [RIOT-OS/RIOT] Tests/pkg_fatfs_vfs: make test fail correctly for samr21-xpro (#11389)

danpetry notifications at github.com
Fri Apr 12 18:27:04 CEST 2019


### Contribution description

The tests/pkg_fatfs_vfs previously hung, rather than failing, which it should do if there's no SD card present.

The reason for the hanging was that the timeouts in the sdcard_spi module were very long. Once this was reduced, the test script would fail, but by throwing an exception rather than running fully and giving an error code, which is different from the behaviour of other tests and IMO not the best way to do it, because an exception should really indicate a failure/error of the test program, not the program under test.

### Testing procedure

`make test` with a SAMR21-xpro.
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11389

-- Commit Summary --

  * drivers/sdcard_spi: Reduce "wait for not busy"
  * tests/pkg_fatfs_vfs: remove exception on failure

-- File Changes --

    M drivers/sdcard_spi/include/sdcard_spi_internal.h (6)
    M tests/pkg_fatfs_vfs/tests/01-run.py (19)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11389.patch
https://github.com/RIOT-OS/RIOT/pull/11389.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11389
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190412/59db1b0c/attachment.html>


More information about the notifications mailing list