[riot-notifications] [RIOT-OS/RIOT] riotnode: node abstraction package (#10949)
notifications at github.com
Sun Apr 14 17:48:53 CEST 2019
miri64 commented on this pull request.
> + def _safe_term_close(self):
+ """Safe 'term.close'.
+ Handles possible exceptions.
+ except AttributeError:
+ # Not initialized
+ except ProcessLookupError:
+ self.logger.warning('Process already stopped')
+ except pexpect.ExceptionPexpect:
+ # Not sure how to cover this in a test
+ # 'make term' is not killed by 'term.close()'
+ self.logger.critical('Could not close make term')
self.logger.critical('Could not close make term')
self.term = None
? Thes way one can check (e.g. in a subclass) if the terminal is running or not.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications