[riot-notifications] [RIOT-OS/RIOT] sam0_common: make RTC implementation common across all sam0 MCUs (#11317)

Dylan Laduranty notifications at github.com
Mon Apr 15 21:46:48 CEST 2019


dylad commented on this pull request.

Tested work on SAML10, SAML11 and SAML21.
One last nitpick and we're good.
You can squash directly.
Thanks for your hard work @benpicco 

> @@ -41,13 +43,45 @@ static rtc_state_t rtc_callback;
 * Thanks to this, the user will be able to set time in 2000's*/
 static uint16_t reference_year = 100;
 
-void rtc_init(void)
+static void _wait_syncbusy(void)
+{
+#ifdef REG_RTC_MODE2_SYNCBUSY
+    while (RTC->MODE2.SYNCBUSY.reg);

please use empty braces `while(foo) {}` for each while.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11317#pullrequestreview-226841825
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190415/7ac50060/attachment.html>


More information about the notifications mailing list