[riot-notifications] [RIOT-OS/RIOT] riotnode: initial import of shell interaction spawn (#11406)

Martine Lenders notifications at github.com
Tue Apr 16 17:46:10 CEST 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
One thing I really like about the test utils in https://github.com/RIOT-OS/Release-Specs/pull/79 are the mixins to activate functionality to interact with a shell command. Based on that I extended #10949's `TermSpawn` (it felt better to extend that class and not `RIOTNode`, but maybe I'm wrong) to a `ShellInteraction` class that is supposed to be used as a base class for these kind of mixins. As an example I provided a shell interaction implementation for `ping6` and `reboot`.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
Currently WIP, so I did not bother to implement tests yet.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Depends on #10949 
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * riotnode: add an empty package directory for 'riotnode'
  * TODO see inside REWORD ME riotnode: add node implementation and tests
  * squash! TODO see inside REWORD ME riotnode: add node implementation and tests
  * testrunner: use riotnode inside
  * testrunner/spawn: take pexpect_path as argument
  * riotnode: Replace pexpect exception value with pattern
  * TODO ADD TESTS riotnode: Remove exception context from inside pexpect implementation
  * riotnode/tests: add a test for term sigkill
  * SQUASH ME WITH NEXT ONE TEST FAILS ON PURPOSE riotnode/tests: add a test for term cleanup
  * riotnode/node: ensure childs are cleaned up
  * riotnode/node.py: use pexpect.close for killing process
  * riotnode/node: remove _kill_term
  * TODO ADD TESTS riotnode/utils: add function to handle subprocesses
  * Merge remote-tracking branch 'cladmi/pr/riotnode/riot_node_abstraction_package' into tools/enh/test-mixins
  * riotnode: initial import of shell interaction spawn
  * riotnode.shell: provide ping6 interaction Mixin

-- File Changes --

    A dist/pythonlibs/riotnode/.coveragerc (2)
    A dist/pythonlibs/riotnode/.gitignore (112)
    A dist/pythonlibs/riotnode/README.rst (28)
    A dist/pythonlibs/riotnode/TODO.rst (24)
    A dist/pythonlibs/riotnode/out.pdf (0)
    A dist/pythonlibs/riotnode/requirements.txt (2)
    A dist/pythonlibs/riotnode/riotnode/__init__.py (11)
    A dist/pythonlibs/riotnode/riotnode/node.py (205)
    A dist/pythonlibs/riotnode/riotnode/shell/__init__.py (1)
    A dist/pythonlibs/riotnode/riotnode/shell/base.py (20)
    A dist/pythonlibs/riotnode/riotnode/shell/gnrc.py (65)
    A dist/pythonlibs/riotnode/riotnode/tests/__init__.py (1)
    A dist/pythonlibs/riotnode/riotnode/tests/node_test.py (197)
    A dist/pythonlibs/riotnode/riotnode/tests/riotnode_test.py (10)
    A dist/pythonlibs/riotnode/riotnode/tests/utils/application/Makefile (16)
    A dist/pythonlibs/riotnode/riotnode/tests/utils/application/create_file.py (36)
    A dist/pythonlibs/riotnode/riotnode/tests/utils/application/echo.py (16)
    A dist/pythonlibs/riotnode/riotnode/tests/utils/application/hello.py (17)
    A dist/pythonlibs/riotnode/riotnode/tests/utils/application/node.py (74)
    A dist/pythonlibs/riotnode/riotnode/tests/utils/application/sigkill_script.py (18)
    A dist/pythonlibs/riotnode/riotnode/utils.py (69)
    A dist/pythonlibs/riotnode/setup.cfg (15)
    A dist/pythonlibs/riotnode/setup.py (48)
    A dist/pythonlibs/riotnode/tox.ini (33)
    A dist/pythonlibs/sitecustomize.py (7)
    M dist/pythonlibs/testrunner/__init__.py (19)
    M dist/pythonlibs/testrunner/spawn.py (4)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190416/fcf7bce8/attachment-0001.html>

More information about the notifications mailing list