[riot-notifications] [RIOT-OS/RIOT] make: don't execute tilde files on test target (#11414)
notifications at github.com
Wed Apr 17 19:50:18 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
My system (Ubuntu 16.04) creates a backup when opening a file with `vim`. This backup is called `filename~`. Due to it being a copy of the file before opening, it also is executable, which is why it is selected for execution with the `make test` target.
This change makes the `TESTS` macro exclude files ending in `~`. This way files ending in `~` are not executed with `make test`.
Since e.g. projects like NextCloud are excluding such files also from their sync [], I think this is fine.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
cp tests/shell/tests/01-run.py tests/shell/tests/01-run.py~
make -C tests/shell/ all test
On current master this results in the tests being executed twice. With this PR it is only executed once.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* make: don't execute tilde files on test target
-- File Changes --
M Makefile.include (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications