[riot-notifications] [RIOT-OS/RIOT] Tests/pkg_fatfs_vfs: make test fail correctly for samr21-xpro (#11389)

Martine Lenders notifications at github.com
Thu Apr 18 12:28:20 CEST 2019


miri64 commented on this pull request.



>  def testfunc(child):
 
     child.expect(u"Tests for FatFs over VFS - test results will be printed in "
                  "the format test_name:result\r\n")
 
-    while True:
-        res = child.expect([u"[^\n]*:\[OK\]\r\n",
-                            u"Test end.\r\n",
-                            u".[^\n]*:\[FAILED\]\r\n",
-                            u".*\r\n"])
-        if res > 1:

Also why is this test removed? Seems quite important to me to check error states.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11389#pullrequestreview-228211432
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190418/45dcc49f/attachment.html>


More information about the notifications mailing list