[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common: RTT and RTC support (#8842)
notifications at github.com
Fri Apr 19 08:30:14 CEST 2019
I have made some alterations: volatile is reduced to what is necessary for proper integrity (`rtt_state.ext_cnt` and `rtt_state.time` only now). A new inline function `_safe_cnt_get()` uses volatile to safely get by re-checking. And, I brought in `irq_disable()` and `irq_restore()` to replace the requirement for a specific callback assignment order. I will work on testing this code tomorrow.
@maribu I re-read my earlier comments, and I feel that at least one comes off as being quite abrasive. That was not my intention, and I apologize if you found it unpleasant. It is difficult to convey that sort of non-literal meaning in a purely textual medium. I do appreciate that you are taking time to review my code.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications