[riot-notifications] [RIOT-OS/RIOT] sys/shell: add loramac shell command (#8855)

Francisco notifications at github.com
Fri Apr 19 14:23:10 CEST 2019


fjmolinas commented on this pull request.

Some minor comments, they where present in the PR before the Rebase, you can address them here or in a separate PR.

> @@ -48,19 +48,18 @@ board.
 
 Depending on the type of radio device, set the `LORA_DRIVER` variable accordingly:
 For example:
-```
+
     LORA_DRIVER=sx1272 make BOARD=nucleo-f411 -C pkg/semtech-loramac flash term

... -C tests/pkg_semtech-loramac/ 

>  will build the application for a nucleo-f411 with an SX1272 based mbed LoRa shield.
 
 The SX1276 is the default value.
 
 The other parameter that has to be set at build time is the geographic region:
 `EU868`, `US915`, etc. See LoRaWAN regional parameters for more information.
 
-```
     LORA_REGION=US915 LORA_DRIVER=sx1272 make BOARD=nucleo-f411 -C pkg/semtech-loramac flash term

... -C tests/pkg_semtech-loramac/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8855#pullrequestreview-226122221
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190419/b07df41e/attachment.html>


More information about the notifications mailing list