[riot-notifications] [RIOT-OS/RIOT] sys/shell: add loramac shell command (#8855)

Francisco notifications at github.com
Fri Apr 19 14:43:24 CEST 2019

fjmolinas requested changes on this pull request.

Some other comments. 

Also your latest commit seems like a different subject unrelated to the PR title, please change it to reflect although IMO it should be a separate PR.

> @@ -277,9 +277,14 @@ void auto_init(void)
 #ifdef MODULE_SX127X

IMO subordinate auto_init_loramac() to MODULE_SX127X is wrong, you are mixing up the mac layer and the network interface

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190419/8feea36f/attachment.html>

More information about the notifications mailing list