[riot-notifications] [RIOT-OS/RIOT] boards/kw41z*: add common configuration and use it with existing kw41z boards (#11044)

Francisco notifications at github.com
Fri Apr 19 15:36:24 CEST 2019


fjmolinas requested changes on this pull request.

In general this looks good but I have problems with the common periph_conf files. 

Unless wired internally to an unboard driver i2c, uart and spi depends on external pins, these are not the same for every board. 

Eg for usb-k241z your are defining two spi. SPI1 is actually only internally connected to the K22 on board and SPI0 is not exposed or connected to any spi interface. The i2c interface for the same board isn't exposed either, only internally connected to the on board K22.

If we look at frdm-k241z many more pins are exposed and therefore options to connect I2C, UART or SPI devices.

IMO in periph_conf_common.h you can leave the common clock configuration but everything else need its separate configuration file.

PS: also it would be interesting to add the option of having two CPU's on a same board, but that is a completely different subject.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11044#pullrequestreview-228694134
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190419/1f6f684c/attachment.html>


More information about the notifications mailing list