[riot-notifications] [RIOT-OS/RIOT] pkg/c25519: cleanup in Makefiles (#11427)
notifications at github.com
Tue Apr 23 09:34:29 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
While running `make distclean`, I noticed that `tests/pkg_c25519` was raising a warning because of `test` target being redefined.
This PR is removing this target.
I also noticed that the package distclean target is using `rm -rf $(PKG_SHAFILE)` with `$(PKG_SHAFILE)` not defined anywhere. This result in a bare call to `rm -rf` which I find not nice. So this is also removing this (in a separate commit). I can drop this from this PR if there's a good reason to keep it.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
A green Murdock should be ok. `make -C tests/pkg_c25519 distclean` should not raise any warning. No call to `rm -rf ` without parameter is done.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* tests/pkg_c25519: remove useless test target
* pkg/c25519: remove inexistent SHAFILE cleanup
-- File Changes --
M pkg/c25519/Makefile (1)
M tests/pkg_c25519/Makefile (3)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications