[riot-notifications] [RIOT-OS/RIOT] Makefile.include: include Makefile.features after $(CPU)/Makefile.include (#11424)

Gaëtan Harter notifications at github.com
Tue Apr 23 12:08:42 CEST 2019


The issue is also present in the `efm32` cpu which depends on a variable defined by `Makefile.include` https://github.com/RIOT-OS/RIOT/blob/d16d911f4238407e2b695a0fb0ab027f41b1ee8b/cpu/efm32/Makefile.features#L9-L11 (where there is even a typo in `TRNG` but fixing it changes nothing).

The problem should however be solved the other way around, with these variables all defined by `Makefile.features`.
It cannot currently be done as `CPU` is defined by `board/*/Makefile.include`, I described the issue in https://github.com/RIOT-OS/RIOT/issues/9913 where the next step would be to move all the `CPU/CPU_FAM/CPU_FAMILY/CPU_MODEL` variables to `Makeflie.features`.
I welcome feedback in the tracking issue if I should PR a change in this direction or how to handle it otherwise.

And indeed, there is also this file https://github.com/RIOT-OS/RIOT/blob/master/makefiles/info-global.inc.mk#L10 that does the evaluation in a different way for getting the dependencies.
Moving these BSP specific variables would require to list them for cleaning them between each evaluation or change this handling but may not be directly possible.

The two way of doing the parsing already leads to inconsistencies:

```
make info-boards-supported | tr ' ' '\n' | grep mips-malta
mips-malta
```
```
BOARD=mips-malta make
There are unsatisfied feature requirements: periph_uart


EXPECT ERRORS!
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11424#issuecomment-485741181
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190423/0e0d089d/attachment.html>


More information about the notifications mailing list