[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: fix of periph_* submodule compilation (#11337)

Gunar Schorcht notifications at github.com
Wed Apr 24 21:25:38 CEST 2019


gschorcht commented on this pull request.



> +            return -1;
+        }
+        _dac_module_initialized = true;
+    }
+
+    _adc2_ctrl_init();
+
+    uint8_t rtcio = _gpio_rtcio_map[dac_pins[line]];
+    uint8_t idx;
+
+    /* try to initialize the pin as DAC ouput */
+    if (gpio_get_pin_usage(_adc_hw[rtcio].gpio) != _GPIO) {
+        LOG_TAG_ERROR("dac", "GPIO%d is used for %s and cannot be used as "
+                      "DAC output\n", _adc_hw[rtcio].gpio,
+                      gpio_get_pin_usage_str(_adc_hw[rtcio].gpio));
+        return DAC_NOLINE;

Yes, since it is just a guard variable for required initialization of the module itself and not for the initialization of each DAC line. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11337#discussion_r278281539
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190424/625b6afd/attachment.html>


More information about the notifications mailing list